Laravel-Backpack / demo

A working demo of Laravel with all Backpack packages installed.

http://backpackforlaravel.com

Other

329 stars 165 forks source link

[v6] Demo theme-switcher is now broken #524

Closed tabacitu closed 1 year ago

tabacitu commented 1 year ago

Bug report

What I did:

Went to our online demo - https://demo-v6.backpackforlaravel.com/admin/dashboard
Tried to switch the theme using the top-right button, that opens the modal

What I expected to happen:

Switch the theme

What happened:

Doesn't switch the theme, only switches the layout. The theme stays as tabler, always. Or at least that's what I think.

CleanShot 2023-06-20 at 17 17 20

tabacitu commented 1 year ago

@jorgetwgroup and @pxpm please have a quick meeting to unblock this 💪

jcastroa87 commented 1 year ago

Hello @tabacitu with this i go deep as i can and discovery why this maybe never work, is because if theme is not loaded in app, switcher will never find views, so i create a provider to register theme in our theme and now is working as expected.

PR: https://github.com/Laravel-Backpack/demo/pull/530

Cheers.