search

Laravel-Backpack / demo

A working demo of Laravel with all Backpack packages installed.
http://backpackforlaravel.com
Other
329 stars 165 forks source link

fix fluent monsters #546

Closed pxpm closed 1 year ago

pxpm commented 1 year ago

WHY

BEFORE - What was wrong? What was happening before this PR?

reported in https://github.com/Laravel-Backpack/demo/issues/534

AFTER - What is happening after this PR?

It works!

HOW

How did you achieve that, in technical terms?

Arrayed names had been removed

Is it a breaking change or non-breaking change?

non

How can we test the before & after?

Try to go to Fluent Monsters

tabacitu commented 1 year ago

Huh. Maybe the fact that I didn't catch this from the error message... means we should throw better error messages? If we encounter this again, let's think about throwing a custom error message there. I'm thinking we can analyze the array a little bit and if doesn't "look like a field definition array" we can say that. I don't know what that would be... maybe it's not an associative array? That'd be a simple fix.