Laravel-Backpack / demo

A working demo of Laravel with all Backpack packages installed.
http://backpackforlaravel.com
Other
323 stars 166 forks source link

Push new file manager in the demo. #562

Closed karandatwani92 closed 11 months ago

karandatwani92 commented 11 months ago

WHY

BEFORE - What was wrong? What was happening before this PR?

image

AFTER - What is happening after this PR?

image

HOW

How did you achieve that, in technical terms?

rm -rf resources/views/vendor/elfinder
php artisan backpack:filemanager:install
karandatwani92 commented 11 months ago

This PR has v3.0.3 FileManager

pxpm commented 11 months ago

@karandatwani92 what you think if we add the publish command in the composer.json post-update / post-install scripts ?

So every time we deploy code to demo, we re-publish the elfinder assets with: php artisan vendor:publish --provider="Backpack\FileManager\FileManagerServiceProvider" --tag=views --force ?

That way we won't forget to re-publish elfinder assets when we change FileManager🙏

karandatwani92 commented 11 months ago

@karandatwani92 what you think if we add the publish command in the composer.json post-update / post-install scripts ?

So every time we deploy code to demo, we re-publish the elfinder assets with: php artisan vendor:publish --provider="Backpack\FileManager\FileManagerServiceProvider" --tag=views --force ?

That way we won't forget to re-publish elfinder assets when we change FileManager🙏

@pxpm Done! Please check & merge🎉

tabacitu commented 11 months ago

So every time we deploy code to demo, we re-publish the elfinder assets with: php artisan vendor:publish --provider="Backpack\FileManager\FileManagerServiceProvider" --tag=views --force

Hmm... why would we re-publish the assets on every install? That's a one-and-done deal for projects, right? Since we don't tell people to add this command to their composer.json I don't think we should add it either. It might trick us into pushing breaking changes into FileManager and thinking they're non-breaking.

tabacitu commented 11 months ago

So every time we deploy code to demo, we re-publish the elfinder assets with: php artisan vendor:publish --provider="Backpack\FileManager\FileManagerServiceProvider" --tag=views --force

Hmm... why would we re-publish the assets on every install? That's a one-and-done deal for projects, right? Since we don't tell people to add this command to their composer.json I don't think we should add it either. It might trick us into pushing breaking changes into FileManager and thinking they're non-breaking.

pxpm commented 11 months ago

Hey @karandatwani92 sorry for the trouble here, I've mistakenly induced you in error to create the entry in composer.json but @tabacitu don't agree with that change.

Can you please remove those changes and put this PR like you had in the beginning by publishing the views?

Once again, sorry for more work 🙏

karandatwani92 commented 11 months ago

Master @pxpm It's OK. UNDO is easy.😜