Open TanNhatCMS opened 5 months ago
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.
Please keep in mind that:
Thank you!
-- Justin Case The Backpack Robot
Hey @TanNhatCMS
Thanks for submitting Vietnamese translations.
@pxpm I have a doubt... He just submitted a Vietnamese translation to base packages, so I find it weird to publish them in the demo again. I think translations are supposed to be automatically picked from base.
@karandatwani92 indeed, some are required to be overwritten so that we say stuff like: deleting entries in demo is disabled.
and such.
But I agree with you, there are some strings that I don't think they need translation here in demo.
Can you do a review of https://github.com/Laravel-Backpack/demo/blob/main/lang/vendor/backpack/en/crud.php and cross check with the package strings, the ones we don't need to be overwriting in the demo ?
We can first delete them from the en
and then update this PR to remove those strings too.
Cheers
Translated into Vietnamese by TanNhatCMS