Laravel-Backpack / demo

A working demo of Laravel with all Backpack packages installed.
http://backpackforlaravel.com
Other
329 stars 165 forks source link

Bug Fix #602

Closed zachweix closed 4 months ago

zachweix commented 4 months ago

When there are no articles, the dashboard gives a 500 error because it is trying to get the date on a non-existent object

WHY

BEFORE - What was wrong? What was happening before this PR?

There was a 500 error sometimes on the Tabler dashboard

AFTER - What is happening after this PR?

There is no more 500 error

HOW

How did you achieve that, in technical terms?

When you are trying to get the date of the most recently published article, if there is none I just get today

Is it a breaking change or non-breaking change?

Non-breaking

How can we test the before & after?

Have a refreshed database and load the dashboard with the Tabler theme

welcome[bot] commented 4 months ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

zachweix commented 4 months ago

While there is nothing wrong with merging this, it turns out I was too quick. I logged in before the database was fully refreshed I guess. But either way, while it's refreshing this will remove the 500 error

karandatwani92 commented 4 months ago

Hey @zachweix

Thanks for the PR. I have assigned my colleague to review & merge. Thanks🙏✌️

welcome[bot] commented 4 months ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!