Laravel-Backpack / demo

A working demo of Laravel with all Backpack packages installed.
http://backpackforlaravel.com
Other
322 stars 166 forks source link

Icon picker use a font that is not available #95

Closed rabol closed 4 years ago

rabol commented 4 years ago

Bug report

What I did:

Installed the Demo

What I expected to happen:

Icon picker to work

What happened:

Icons are not shown

this is the console error:

What I've already tried to fix it:

this is the problem: in file: /vendor/backpack/crud/src/resources/views/crud/fields/icon_picker.php

$fontIconFilePath = asset('packages/bootstrap-iconpicker/icon-fonts/font-awesome-5.10.1/css/all.min.css');

the font file is not available

Backpack, Laravel, PHP, DB version:

The version that the demo installs

welcome[bot] commented 4 years ago

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication mediums:

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

FrodeMMeling commented 4 years ago

This is easily solved by enabling font-awesome. go to: config/backpack/base.php and uncomment line 54: 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.10.2/css/all.min.css',

pxpm commented 4 years ago

Hi guys thanks for spoting this out, i think @FrodeMMeling solution does not solve the problem, just masks it.

When uncommenting the line the icons apear in the picker but the error persists in console.

Could you confirm that @FrodeMMeling ?

Thanks in advance, Pedro

vonsogt commented 4 years ago

you should make sure the version of font-awesome is same as it defined at source

check your version in here: https://github.com/Laravel-Backpack/CRUD/blob/master/src/resources/views/crud/fields/icon_picker.blade.php#L29

after you change the version that you wanted: download and copy this webfonts folder to your public directory https://github.com/FortAwesome/Font-Awesome

for more, check out my PR at CRUD: https://github.com/Laravel-Backpack/CRUD/pull/2363

tabacitu commented 4 years ago

@vonsogt 's PR has been merged into 4.1, along with using la la-home syntax for LineAwesome instead of fa fa-home. That way we avoid any conflicts going further. Thanks again for submitting it!

Unfortunately the fix has to be pushed as a breaking change. Until then, his solution above should work. Closing this since it's solved with Laravel-Backpack/CRUD#2363