Laravel-Backpack / medialibrary-uploaders

MIT License
9 stars 3 forks source link

[WIP] Custom uploaders #3

Closed pxpm closed 1 year ago

tabacitu commented 1 year ago

Hey Pedro.

Tried to use this branch instead of main, as we talked yesterday in our meeting. Unfortunately, I can't get this working either. On that other branch:

Now, as soon as I checked out this branch, I get a different error: CleanShot 2023-02-25 at 10 01 49 Stack trace here: https://flareapp.io/share/xmNgrl3P#F58

I'm sorry man, but this isn't ready for me to review. Wherever I turn, there's a bug. It's frustrating.

Please:

When the above is finished, THEN it makes sense for me to review. THEN we can talk code quality. Renaming classes. Code refactoring. Etc. Until then... I'm just wasting my time finding bugs that should be finding and solving. Let's be efficient here - what you give me should work as documented. That's the minimum.

Ping me on Discord when it's ready, and I'll take a look at the fully working PR that day or the next day. Come on, we can do this 💪

Cheers!

PS. Also reviewed the associated CRUD PR - https://github.com/Laravel-Backpack/CRUD/pull/4921 - I think that one will be easier to bring to a state we can merge.