Laravel-Backpack / revise-operation

An admin interface for venturecraft/revisionable - audit log for your Eloquent entries.
Other
42 stars 10 forks source link

prevents lazy loading of revision history #23

Closed pxpm closed 1 year ago

pxpm commented 1 year ago

WHY

BEFORE - What was wrong? What was happening before this PR?

reported in #22

AFTER - What is happening after this PR?

We eager load the revisionHistory

Is it a breaking change or non-breaking change?

No

How can we test the before & after?

Add to service provider:

use Illuminate\Database\Eloquent\Model;

public function boot()
{
    Model::preventLazyLoading(! $this->app->isProduction());
}

Try to load a table with revisions enabled.

welcome[bot] commented 1 year ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!