search

Laravel-Backpack / theme-coreuiv2

UI that uses CoreUI v2 and Bootstrap v4, provided as a legacy theme for Backpack v6.
MIT License
5 stars 4 forks source link

Fix Developer Link Only In The Footer #36

Closed marco-wildermuth closed 9 months ago

marco-wildermuth commented 9 months ago

Greetings, it appears that a bug has been introduced with this commit: https://github.com/Laravel-Backpack/theme-coreuiv2/commit/e582bf55c8ceb2a0bbb4fbff7c7198378f67fdc1#diff-bc1c12ab7e08a2b625d235d8eb97ca13f08d2e277abe7c4f37239b6c980a75fcR1 The second condition was replaced by config('developer_link') but it should have been replaced by backpack_theme_config('developer_link').

This has the effect that it's not possible to show only the Handcrafted by X in the footer using the UI config. show_powered_by has to be enabled too to show it, which will also show the Powered by Backpack for Laravel.

pxpm commented 9 months ago

Thanks @marco-wildermuth 🙏 really appreciated.

I've just confirmed and we don't have the same problem in the other themes, we missed it here 😞

Sorry for the trouble and thanks again for the PR 👍

Cheers

marco-wildermuth commented 9 months ago

Hi @pxpm , no problem at all. Thanks to you and the other maintainers for providing this useful theme.