Closed karandatwani92 closed 1 year ago
@tabacitu
Should we remove the font too from theme_styles.blade.php
? They are in core-ui2 theme but not in tabler theme.
- {{-- Source Sans Font --}}
- @bassetArchive('https://github.com/adobe-fonts/source-sans/releases/download/3.046R/WOFF2-source-sans-3.046R.zip', 'source-sans-pro')
- @basset(base_path('vendor/backpack/theme-coreuiv4/resources/assets/libs/source-sans-pro.css'), 'source-sans-pro/source-sans-pro.css')
Should we remove the font too from theme_styles.blade.php? They are in core-ui2 theme but not in tabler theme.
Afaik:
So each theme brings their own font, practically.
Damn it! Sorry @karandatwani92 ... 🤦♂️ I merged this by mistake... when I merged another PR.
The issues above still stand, the ones in my inline comments - so please fix them in a different PR:
Added https://github.com/Laravel-Backpack/theme-coreuiv4/issues/26 so we don't forget about it.
Solves #14 #15
Trying to fix the following: