search

Laravel-Backpack / theme-coreuiv4

UI for Backpack v6 that uses CoreUI v4 and Bootstrap v5.
MIT License
7 stars 4 forks source link

Missing Attributes Log Errors #38

Closed karandatwani92 closed 1 year ago

karandatwani92 commented 1 year ago

Theme tabler got a lot of attributes in the config file, which are missing in other themes. Thus Error gets logged on every request if using coreui-v2 or v4.

theme-coreuiv4

https://github.com/Laravel-Backpack/theme-tabler/blob/main/config/theme-tabler.php

theme-coreuiv2(missing attributes)

https://github.com/Laravel-Backpack/theme-coreuiv2/blob/main/config/theme-coreuiv2.php

theme-coreuiv4(missing attributes)

https://github.com/Laravel-Backpack/theme-coreuiv4/blob/main/config/theme-coreuiv4.php

Error type(this could be any missing key)

Screenshot 2023-07-12 at 7 18 02 PM

tabacitu commented 1 year ago

It's been fixed on all themes, on main - just hadn't been tagged yet. If I remember correctly it was @pxpm who implemented the fix.

I've just tagged new versions of CRUD and all 3 themes. A composer update should pull the new ones and fix this problem. Please let me know if it doesn't and we'll reopen.

Cheers!

karandatwani92 commented 1 year ago

Hey @tabacitu, I'm unable to understand. it's fixed or Not

I'm using its updated version on my project. It's throwing ERRORS. When I'm using the demo, it's okay NO ERRORS.

I have not published any theme config file. What could be the issue?

BACKPACK PACKAGE VERSIONS:

backpack/backupmanager: v5.0.0 backpack/basset: 1.0.1 backpack/crud: 6.0.6 backpack/devtools: 2.0.2 backpack/editable-columns: 3.0.1 backpack/filemanager: 3.0.2 backpack/generators: v4.0.1 backpack/logmanager: v5.0.0 backpack/menucrud: v4.0.1 backpack/newscrud: v5.0.0 backpack/pagemanager: 3.2.0 backpack/permissionmanager: 7.0.0 backpack/pro: 2.0.8 backpack/settings: 3.1.0 backpack/theme-coreuiv2: 1.1.4 backpack/theme-coreuiv4: 1.0.4 backpack/theme-tabler: 1.0.6

tabacitu commented 1 year ago

I have no idea, to be honest. If you install v6 and all themes in a new project, do you still get the problem? Or is it isolated to this one project you have?

karandatwani92 commented 1 year ago

I have no idea, to be honest. If you install v6 and all themes in a new project, do you still get the problem? Or is it isolated to this one project you have?

@tabacitu I created a new project, a fresh installation and the bug exists.

tabacitu commented 1 year ago

We discussed in today's team meeting. A good fix is probably to add the missing config to Backpack's config/ui.php. If it's used in DataTables / ListOperation, then it's a config all themes should have, not just one. And ui.php is exactly that - the fallback config for all themes.

karandatwani92 commented 1 year ago

Solved https://github.com/Laravel-Backpack/CRUD/pull/5230