Laravel-Backpack / theme-tabler

UI for Backpack v6 that uses Tabler and Bootstrap v5.
MIT License
21 stars 12 forks source link

Fix dark mode overlay on elFinder iframe #116

Closed jcastroa87 closed 11 months ago

jcastroa87 commented 11 months ago

This PR will fix dark mode on elFinder https://github.com/Laravel-Backpack/theme-tabler/issues/103

pxpm commented 11 months ago

Hey @jorgetwgroup

I've sent https://github.com/Laravel-Backpack/theme-tabler/pull/118 to address the colorMode issue.

I've just asked for @promatik confirmation, I think there is no issue in making colorMode globally available.

After that PR gets merged you can access color mode with window.parent.colorMode.result, so something like: let theme = window.parent.colorMode?.result === 'dark' ? 'dark' : 'default';

Cheers

jcastroa87 commented 11 months ago

Hi @pxpm thank you very much about it, is almost work perfect, i update https://github.com/Laravel-Backpack/FileManager/pull/35 but im getting this error when i change color on menu:

Screenshot 2023-07-19 at 20 44 59

Look like for a while colorMode became null, but im using tabler, so can not be null.

Thanks again.

jcastroa87 commented 11 months ago

Hi @pxpm thank you very much about it, is almost work perfect, i update Laravel-Backpack/FileManager#35 but im getting this error when i change color on menu:

Screenshot 2023-07-19 at 20 44 59

Look like for a while colorMode became null, but im using tabler, so can not be null.

Thanks again.

this is fixed

jcastroa87 commented 11 months ago

Fix the conflict