Laravel-Backpack / theme-tabler

UI for Backpack v6 that uses Tabler and Bootstrap v5.
MIT License
26 stars 14 forks source link

Prettier error pages #128

Closed promatik closed 1 year ago

promatik commented 1 year ago

Quick question before merging; This PR adds a translation;

image

"Take me Home" button.

What should we do about it? 1) translate in the theme? 2) translate in crud? 3) remove the button so we don't need to add translations?

I think we should make the theme translatable, because there are other string there, that are currently not translated 😬 And others my come up, like the in the https://github.com/Laravel-Backpack/theme-tabler/pull/120


Depends on https://github.com/Laravel-Backpack/CRUD/pull/5276

tabacitu commented 1 year ago

In this case, perhaps we can avoid the translation, by having buttons that show icons for BACK and HOME?

tabacitu commented 1 year ago

Otherwise I'm ok with adding these two translation strings to CRUD. They can be used in the default error views. Then themes use them too when they customize the error views. Makes sense right?

promatik commented 1 year ago

Translations added here; https://github.com/Laravel-Backpack/theme-tabler/pull/136

promatik commented 1 year ago

image

image

image