Laravel-Backpack / theme-tabler

UI for Backpack v6 that uses Tabler and Bootstrap v5.
MIT License
21 stars 12 forks source link

Progress widgets text color fix #133

Closed karandatwani92 closed 10 months ago

karandatwani92 commented 11 months ago

Solves #132

Before

text-white was not applied to the description while using the progress widget.

Screenshot 2023-08-11 at 1 23 04 PM

and when I used the progress_white widget the output was:

Screenshot 2023-08-11 at 1 23 19 PM

After

Tested with & without text-white bg-primary. Now works both ways ✅

Screenshot 2023-08-11 at 5 28 22 PM

Screenshot 2023-08-11 at 5 29 06 PM

Perfectly works in dark mode too

Screenshot 2023-08-11 at 5 30 25 PM

Screenshot 2023-08-11 at 5 32 43 PM

pxpm commented 11 months ago

Hey @karandatwani92 thanks for the PR and the explanation.

The colors look fine and are perfectly readable, but the font changed, notice on the following screenshoot: image

karandatwani92 commented 11 months ago

@pxpm done🎉

pxpm commented 11 months ago

Still very different from what it was before, and I kinda like it more how it was before image

Notice that the text is all uppercase on the original version

karandatwani92 commented 11 months ago

Hey @pxpm I understand that you are comparing it to what it was earlier but to make it similar to other card widget, We must use the same class which other widgets are using. I found other widgets using card-title for their title.

This would maintain consistency among all widgets titles provided by the theme.

tabacitu commented 10 months ago

image

I'm with Pedro on this one. I don't like how it looks afterwards either. Let's find a way for it to look like it did before.

tabacitu commented 10 months ago

I love the first post in this thread btw. So clear with before&after and screenshots ❤️ Gj.