Laravel-Backpack / theme-tabler

UI for Backpack v6 that uses Tabler and Bootstrap v5.
MIT License
21 stars 12 forks source link

[FEATURE] Show/hide password button toggler #154

Closed promatik closed 6 months ago

promatik commented 7 months ago

Based on https://github.com/Laravel-Backpack/theme-tabler/pull/120. @siberfx suggested this feature.

image

image

karandatwani92 commented 6 months ago

Hey @promatik

Works well in mobile & desktop.

But strange popup on the Safari browser. It opens the password save pop-up when I click the eye icon!

It comes whenever we input/change the password and move focus to the eye icon.

To compare the behaviour, I checked the https://accounts.zoho.in/signin page. It doesn't open there!

promatik commented 6 months ago

Hey @karandatwani92, I copied the code form https://preview.tabler.io/sign-in.html, maybe it's a "bug" in tabler it self.

I'll merge this one as is, and we'll probably release the fix later, since the bug only happens on click of the button AND in Safari.

It would be nice if Apple ceased to develop their browser, since it's always full bugs you could help me debug this one 👌