Closed tabacitu closed 1 year ago
Hey @maurohmartinez ,
Here it is, I went through Theme-Tabler once to highlight what I see as quirks/todos/fixes-needed. It's before I had my coffee so please excuse my lack of enthusiasm 😅
These are some minor things that do need fixing. This final pixel-pushing session should make Theme-Tabler look polished so that we can start filming 💪 Let's do thissss!!
Todo
These PR should be checked and merged in order to fix items noted above.
CRUD -> https://github.com/Laravel-Backpack/CRUD/pull/5068 demo -> https://github.com/Laravel-Backpack/demo/pull/507 pro -> https://github.com/Laravel-Backpack/PRO/pull/153 tabler -> https://github.com/Laravel-Backpack/theme-tabler/pull/40
Just for the record, I tested every change both on coreui2 and coreui4 to make sure it didn't break those.
One important note...
@tabacitu I discovered something while trying to fix these (and other things). Iconpicker field is broken for Tabler
. Initially, when looking at the iconpicker docs, I saw that it is compatible with bootstrap 3.x
and bootstrap 4.x
, but it doesn't say anything about bootstrap 5.x
. Because of that I assumed it was not going to work with coreuiv4
either. But guess what... it does work 🤔
Any ideas? Any advice? Should I create an issue and let someone else take over it?
Todo: