We added the horizontal overlap layout because it looks pretty on dashboards and custom views. But it does NOT look pretty on CRUD views.
Plus it adds complexity in the theme config file, because you have to specify all the URLs that use that layout. That... is... confusing. And incomplete. As @pxpm explained in https://github.com/Laravel-Backpack/theme-tabler/pull/58... what do you do about pages with URL segments, like /{id}/edit/?
So what we should probably do in this case... is to make the horizontal overlay layout look good on CRUD pages too, in a non-breaking way. For example, on the List operation it could look like this:
If we only change two things using CSS:
the color of the heading text (make it white)
the color of the breadcrumbs last text (make it white)
So I think we should
[x] add some extra CSS, for this particular layout, that make it pretty on all CRUD pages;
[x] remove the urlsUsingOverLapEffect config;
[x] remove the workaround Pedro added in the ServiceProvider;
If we do the above... I think this will be pretty enough to use it as the DEFAULT layout. It would be THAT pretty.
tabacitu
commented
1 year ago
We added the horizontal overlap layout because it looks pretty on dashboards and custom views. But it does NOT look pretty on CRUD views.
Plus it adds complexity in the theme config file, because you have to specify all the URLs that use that layout. That... is... confusing. And incomplete. As @pxpm explained in https://github.com/Laravel-Backpack/theme-tabler/pull/58... what do you do about pages with URL segments, like
/{id}/edit/?So what we should probably do in this case... is to make the horizontal overlay layout look good on CRUD pages too, in a non-breaking way. For example, on the List operation it could look like this:
If we only change two things using CSS:
So I think we should
urlsUsingOverLapEffectconfig;If we do the above... I think this will be pretty enough to use it as the DEFAULT layout. It would be THAT pretty.