Laravel-Backpack / theme-tabler

UI for Backpack v6 that uses Tabler and Bootstrap v5.
MIT License
21 stars 12 forks source link

[Bug] Getting Started widget typo and location #71

Closed tabacitu closed 1 year ago

tabacitu commented 1 year ago

The getting started widget is instructing me in step 4 to change the config in base.php file but it should be ui.php file. Then I noticed this widget is provided by the theme… which… is wrong. It should be provided by CRUD. I see more files in theme-tabler views/inc that should be moved to CRUD - alerts, widgets… maybe… I don’t know…

phpfour commented 1 year ago

Hi @tabacitu, we are loading the dashboard.blade.php file from the themes which in turn loads the inc\getting_started.blade.php file within the theme.

When you say It should be provided by CRUD – do you mean moving both these files (along with necessary dependents) to CRUD?

tabacitu commented 1 year ago

Yes

phpfour commented 1 year ago

Hey @tabacitu

We are good to move the dashboard view and the getting started widget to the CRUD. I have made sure that the toggles work in all three themes and the styling is consistent (as much as possible).

Screenshots:

CleanShot 2023-06-29-16 35 16

CleanShot 2023-06-29-16 35 47

CleanShot 2023-06-29-16 36 15 (yes, I've noticed the gravatar issue – will open a separate PR for that)

PRs:

https://github.com/Laravel-Backpack/CRUD/pull/5150 https://github.com/Laravel-Backpack/theme-tabler/pull/88 https://github.com/Laravel-Backpack/theme-coreuiv4/pull/27 https://github.com/Laravel-Backpack/theme-coreuiv2/pull/16

Let me know if you have any views.

Thanks!

tabacitu commented 1 year ago

Awesome! Thank you @phpfour , they're all merged now 🎉