Closed tabacitu closed 1 year ago
Hi @tabacitu, we are loading the dashboard.blade.php
file from the themes which in turn loads the inc\getting_started.blade.php
file within the theme.
When you say It should be provided by CRUD
– do you mean moving both these files (along with necessary dependents) to CRUD?
Yes
Hey @tabacitu
We are good to move the dashboard view and the getting started widget to the CRUD. I have made sure that the toggles work in all three themes and the styling is consistent (as much as possible).
Screenshots:
(yes, I've noticed the gravatar issue – will open a separate PR for that)
PRs:
https://github.com/Laravel-Backpack/CRUD/pull/5150 https://github.com/Laravel-Backpack/theme-tabler/pull/88 https://github.com/Laravel-Backpack/theme-coreuiv4/pull/27 https://github.com/Laravel-Backpack/theme-coreuiv2/pull/16
Let me know if you have any views.
Thanks!
Awesome! Thank you @phpfour , they're all merged now 🎉
The getting started widget is instructing me in step 4 to change the config in base.php file but it should be ui.php file. Then I noticed this widget is provided by the theme… which… is wrong. It should be provided by CRUD. I see more files in theme-tabler views/inc that should be moved to CRUD - alerts, widgets… maybe… I don’t know…