Laravel-Backpack / theme-tabler

UI for Backpack v6 that uses Tabler and Bootstrap v5.
MIT License
21 stars 12 forks source link

[v6][Bug] doubleTopBarInHorizontalLayouts squishes and unaligns the logo text in the menu bar #75

Closed tabacitu closed 1 year ago

tabacitu commented 1 year ago

In Tabler theme, when using the horizontal layout with “doubleTopBarInHorizontalLayouts” set to false, the menubar logo gets smaller and squished when it’s a text, so it’s no longer aligned with the menu items. I don’t know if I mind it being smaller, that might actually be better. But it should be aligned with the menu items (vertically), otherwise it looks like a bug.

tabacitu commented 1 year ago

Rephrased: In a fresh new Laravel project with Backpack v6 installed and the Tabler theme, I've change the tabler config file to use the horizontal layout. So I went from this:

CleanShot 2023-06-26 at 20 57 53@2x

To this:

CleanShot 2023-06-26 at 20 58 15@2x

All good so far, looking nice.

BUT when I go in the config file and change doubleTopBarInHorizontalLayouts to false, it will merge the two top bars (good) but it will also squish the text and raise it, so it's no longer aligned with the menu items:

CleanShot 2023-06-26 at 20 59 45@2x

jcastroa87 commented 1 year ago

Fixed with: https://github.com/Laravel-Backpack/theme-tabler/pull/82

tabacitu commented 1 year ago

Let's move the conversation to https://github.com/Laravel-Backpack/theme-tabler/pull/82 then