search

Laravel-Lang / lang

List of 126 languages for Laravel Framework, Laravel Jetstream, Laravel Fortify, Laravel Breeze, Laravel Cashier, Laravel Nova, Laravel Spark and Laravel UI.
https://laravel-lang.com/packages-lang.html
MIT License
7.5k stars 3.04k forks source link

Publish a Stable Version for Laravel 5.8 #1055

Closed tanmuhittin closed 5 years ago

tanmuhittin commented 5 years ago

I am preparing a PR for https://github.com/barryvdh/laravel-translation-manager in order to publish Laravel base lang files when a new locale added. I am planing to use this repository via https://github.com/andrey-helldar/laravel-lang-publisher/pull/3 but https://github.com/barryvdh/laravel-translation-manager requires minimum stability:stable. So I need a stable version of this package for Laravel 5.8

andrey-helldar commented 5 years ago

I support!

In my opinion, splitting versions by branch name is not a very good solution.

Alternatively, a major version can be used as a stable branch.

For example:

^3.0 >> Laravel 5.7 and below
^4.0 >> Laravel 5.8+

Connecting the package to projects depends on the version, not on the branches. Versions can be put on different branches. For example:

master >> 3.0.62, 3.0.63...3.n+1
laravel58 >> 4.0.0, 4.0.1, 4.n+1

This will allow you to make the necessary changes only in the desired branch, as well as use stable versions instead of being developed.

caouecs commented 5 years ago

oki dokki

I will do it tomorrow

andrey-helldar commented 5 years ago

I am sure that you, @caouecs, can do it without me, but anyway I will post a picture here 😊

2019-04-15_22-53-19

(Screenshot from my repository, but the point is clear)

andrey-helldar commented 5 years ago

@caouecs, I prepared the necessary changes for both branches ☝ 😊

andrey-helldar commented 5 years ago

@caouecs, thank you!

@tanmuhittin, use version ^2.0 version of andrey-helldar/laravel-lang-publisher for a stable Laravel 5.8 and above or ^1.0 for Laravel 5.3-5.7 inclusive.