[V11] Remove keys and empty files

Laravel-Lang / publisher

Publisher provides functionality for working with application localization

https://laravel-lang.com/packages-publisher.html

MIT License

211 stars 25 forks source link

[V11] Remove keys and empty files #187

Closed mohamedsabil83 closed 2 years ago

mohamedsabil83 commented 2 years ago

Lang Publisher Version: 11.1.6
Laravel Version: 8.74
PHP Version: 8.0

Description:

I'm using Arabic locale. After upgrading to v11.1.6 from v10:

When run php artisan lang:update the following keys deleted from the validation file (accepted_if, declined, declined_if, prohibits). Also, the attributes array became empty.
When adding any locale, e.g. fr, the package publishes the files with an empty array as content.

andrey-helldar commented 2 years ago

Fixed in the 11.1.7 version.

Thank you!

mohamedsabil83 commented 2 years ago

Thank you for the quick fix.

I forgot to say that some phrases were removed from the json file like some shown in the image. Is it a bug or a new approach when publishing locales?

Screenshot from 2021-12-07 02-10-43

andrey-helldar commented 2 years ago

You're welcome!

The removed translations are specific to Laravel Nova.

For example,

If it is not installed in the project, then these keys will not be installed in the application.

andrey-helldar commented 2 years ago

If your application uses many of the keys to be installed, then you can create a new package using this template and specify everything you need in it.

Or, for example, copy the Nova files into it ¯_(ツ)_/¯

mohamedsabil83 commented 2 years ago

I see. It's ok with me just asking to be sure if that just the reason.

Thank u again for your hard work 👍🏽