Fix where annotation - Githubissues

LaravelCollective / annotations

Route and Event Annotations for the Laravel Framework

MIT License

365 stars 73 forks source link

Fix where annotation #83

Closed alexfoo closed 5 years ago

alexfoo commented 5 years ago

Related to #59

I will leave a comment there on how it's used. I also added a test.

It's directed to master since @loonytoons said the 5.8 branch would end up in there and this is based on it.

Not sure when this broke or if it ever worked...

loonytoons commented 5 years ago

legend, thanks @alexfoo Can you update to point at the 5.8 branch, and merge in the latest to tidy up the diff? I might an extra test just to make sure that the where within the Get annotation always works.

The mix of tabs and spaces in these files is also doing my head in 😂 but I'll update that in another MR. Not sure I have perms to add a StyleCI integration, so might add a seperate mechanism to make consistent styling easier

loonytoons commented 5 years ago

Also I don't think will have ever worked for where's on individual routes, just on the collection annotations

loonytoons commented 5 years ago

Actually realised I could update the base branch myself, thanks for this @alexfoo 🙌