search

LaravelCollective / remote

Remote SSH Access for the Laravel Framework
MIT License
276 stars 106 forks source link

5.2 tag does not work with Laravel 5.2 #23

Closed ikari7789 closed 8 years ago

ikari7789 commented 8 years ago

Please be aware that merely updating the composer packages to 5.2 does not allow this to work with Laravel 5.2.

There was deprecated code being used that was also removed from Laravel in 5.2. This was already addressed in PR #22.

adamgoose commented 8 years ago

Yeah, my bad... The SP is deferred, so I missed it in my testing. :P Sorry about that! Tagged v5.2.1.

ikari7789 commented 8 years ago

No worries there. My only question is why ignore the pull request that was already made?

adamgoose commented 8 years ago

Sorry about that... I appreciate your efforts. I just had to go through all of our repositories and get them all set up for 5.2 releases. I wasn't even looking at PRs, and had forgotten that you had made one. :/

adamgoose commented 8 years ago

https://twitter.com/LaraCollective/status/679580192554156032

ikari7789 commented 8 years ago

Completely understood. Thanks for the explanation!

Sent from my iPhone

On Dec 23, 2015, at 17:31, Adam Engebretson notifications@github.com wrote:

Sorry about that... I appreciate your efforts. I just had to go through all of our repositories and get them all set up for 5.2 releases. I wasn't even looking at PRs, and had forgotten that you had made one. :/

― Reply to this email directly or view it on GitHub.