search

LaravelDaily / laravel-charts

Package to draw charts in Laravel with Chart.js
MIT License
522 stars 116 forks source link

[FTR] Add feature group_by_function to group by case insensitive strings #102

Closed ITMobilityControl closed 1 year ago

ITMobilityControl commented 1 year ago

Use case: Users write the same string but with different capital letters. Now you can add strtolower for example to combine these strings into one group.

Before: Schermafbeelding 2023-03-31 103748

After: Schermafbeelding 2023-03-31 103729

PovilasKorop commented 1 year ago

@ITMobilityControl sorry but I'm not comfortable merging this. Using any function that you suggest opens up the possibility for all kinds of security issues which we couldn't validate.

ITMobilityControl commented 1 year ago

@PovilasKorop hmm yeah understandable, didn't think about that! Is there any way to do this with the current state of the package?

I've tried a lot of ways but couldn't find a suitable option like this one (sadly)...

PovilasKorop commented 1 year ago

@ITMobilityControl nope, unfortunately I don't see an easy solution here

ITMobilityControl commented 1 year ago

@PovilasKorop okay! Thanks for the quick response. I'll see if there's another way! :)