LaravelDaily / laravel-charts

Package to draw charts in Laravel with Chart.js
MIT License
532 stars 118 forks source link

group_by_field_format missing in documentation #32

Closed neppoz closed 4 years ago

neppoz commented 4 years ago

Hi,

i initially struggled to to set the correct datetime format when grouping by a datetime field. So i noticed in LaravelChart the undocumented group_by_field_format

LaravelChart.php Line 106 $this->options['group_by_field_format'] ?? 'Y-m-d H:i:s',

Could be useful for those using CET time settings or those who have model mutators otherwise the query will fail.

PovilasKorop commented 4 years ago

@neppoz thanks for noticing! Would you be able to add it to the documentation as a Pull Request, please?

neppoz commented 4 years ago

For sure. Please see https://github.com/LaravelDaily/laravel-charts/pull/33

PovilasKorop commented 4 years ago

Fixed.