search

LaravelDaily / laravel-permission-ui

81 stars 18 forks source link

Package name should follow the parent package #1

Closed alaminfirdows closed 2 years ago

alaminfirdows commented 2 years ago

This is going to be the most popular extension for managing the spatie/laravel-permission with a great user interface. I'm super excited to use this package for my future project.

I am going through this package and found that spatie publish their package as spatie/laravel-permission. As this package is extending spatie's laravel permission package, you should follow the parent and set the package name as laraveldaily/laravel-permission-ui. (singular form)

It will help users to relate to the parent package and manage easily.

- laraveldaily/laravel-permissions-ui
+ laraveldaily/laravel-permission-ui
atiq-ur commented 2 years ago

I appreciate it.

PovilasKorop commented 2 years ago

@alaminfirdows I agree, good suggestion, will rename.

alaminfirdows commented 2 years ago

@PovilasKorop I’m waiting to submit some other PRs, depending on this issue.

PovilasKorop commented 2 years ago

@alaminfirdows thanks, for now hold on with PRs, we got a lot of feedback so will fundamentally restructure some things for v0.2 in upcoming week(s) and then will accept PRs.

PovilasKorop commented 2 years ago

@alaminfirdows ok renamed the package and the config, released v0.1.2. Will move on to other issues, one by one.