search

LaravelRUS / SleepingOwlAdmin

🦉 Administrative interface builder for Laravel (Laravel admin)
http://sleepingowladmin.ru/
MIT License
805 stars 217 forks source link

AdminColumn::link->setLinkAttributes() renders incorrectly #793

Closed Acerbic closed 6 years ago

Acerbic commented 6 years ago

Version in Composer.json

"laravelrus/sleepingowl": "4.*@dev" (actual - 4.99.99)

Steps to reproduce

  1. Add a section with a DisplayDatatables display with a column type 'link'
  2. Set custom attributes to the link like this: ->setLinkAttributes(['class' => 'btn btn-xs'])

What is expected?

  1. <a class="btn btn-xs">

What is actually happening?

  1. <a class=&quot;btn btn-xs&quot;>

    The template file "default.column.link" should use {!! !!} instead of {{ }} for attributes. It is safe, since attributes builder class already uses htmlentities().

Butochnikov commented 6 years ago

works on branches dev and new