search

LaravelRUS / localized-carbon

A localizable version of Carbon
138 stars 62 forks source link

Provide dutch translation #11

Closed freekmurze closed 10 years ago

freekmurze commented 10 years ago

Hi,

great package! I've provided the Dutch translations.

Amegatron commented 10 years ago

@freekmurze Hi! Thanks for contributing :+1: But please see my comment to your code before I merge. Also it seems that the lang-file is not necessary since all plurals in Dutch are just like singles but ending on "en" and all pluralizing logic is done inside the format method without calling Lang::choice. Correct me if I'm mistaking :)

freekmurze commented 10 years ago

@Amegatron Plurals in Dutch are not just the singular + "en". Most of the time a vowel disappears in the plural form: eg: "minuut" vs "minuten", "week" vs "weken", ...

And there is an exception: "uur" is the same in singular as plural when a number precedes this unit.

I've corrected the language-file and modified the NlDiffFormatter so it uses the language file, and have thoroughly tested it in a project.