LargeCrowd / pe

0 stars 0 forks source link

Stacking of `find` commands can be confusing #5

Open LargeCrowd opened 4 months ago

LargeCrowd commented 4 months ago

The use of stacking the find command can be confusing. E.g. find role/supplier role/client finds all people that have roles that are either supplier or client. However, entering find role/supplier followed by find role/client looks for people with roles supplier and client. It may lead to confusion on how the command works

A fix would be to clearly explain this in the UG. This particular use case is not that clearly explained.

image.png

image.png

nus-pe-bot commented 4 months ago

Team's Response

We believe this is sufficiently explained in the UG.

image.png

The first sentence and second bullet point mentions that it shows persons matching any of the fields, and also provided a relevant example.

image.png

The stacking example mentions that it shows all persons who are Employee and have the tag friends, explaining with relevant examples. This given example is similar to the use case you mentioned. It is difficult and not practical to cover the exact use case you mentioned, since there are 5 different fields the find command can take, so there are many different possible combinations of uses.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]