mbrshipend field

[sarangtc]

there is a mbrshipend in the latest commit for MemberQuery.php, but this field is not in any upgrade or starting sql. Need to figure out what happened.

[Larian77]

Yes, I introduced the field at some point in version 5 in the German version with a simple database addition without adapting the routines. I thought it was already added in version 0.7 by the maintainers of openbiblio at that time. I'll have another look at it.

[375michael40veit]

@sarangtc @Larian77 Almost all bugfixes for 0.8.1 are reproducible, many thanks to @sarangtc. However, this error shown here is not (yet) completely comprehensible to me. A memebership end can be set.

• In the staff area: The membership expiry time is displayed when the member profile is called up.
• In the member area: This time is also shown in the member profile, but not clearly marked or indicated.

What else should the membership end do?

[375michael40veit]

@sarangtc @Larian77 bug fixed: Installing english sample version. So I think, it isn't necessary to exclude mbrshipend in file MemberQuery.php

[sarangtc]

OK, my db must have been out of date, it was not there a few years back, and is not in any of the upgrade scripts.

I do not see any actions for members who have surpassed their end date.

[sarangtc]

New Member form labels this "Membership Ends" and the member view page labels this "paid until" (which is both inconsistent with the above image and not title case as the other labels in the table

[Larian77]

A brief explanation: The mbrshipend field can be filled or empty. We have members of the association who can always borrow without an end date (in which case the field is empty). There are also (mainly) users who pay for a month, half a year or a whole year, for whom the end date is relevant because they can no longer borrow after that. In the German version, both fields (at least in 0.8) are still called ‘bezahlt bis’ (paid until)

[Larian77]

@375michael40veit @sarangtc But if I see it correctly, mbrshipend should already be added in the 0.7.1 update function if it was missing before or am I seeing it wrong (just had a quick look over it, didn't search exactly)

[sarangtc]

Regarding the mbrshipend field can be filled or empty: The member.sql in the 0.8.1 folder states that this cannot be null! So we need to change that then.

and regarding mbrshipend being in the 0.7.1 update function, cannot see it anywhere in the UpgradeQuery.php class or in the update.php

[Larian77]

Sorry, my fault, if it's empty it isn't NULL its '0000-00-00' There are some functions where i check if mbrshipend is '0000-00-00' and after them I treat it as if it is empty

[sarangtc]

I couldn't find these functions, could you tell me where they are located?