search

LarissaReames-NOAA / MPASSIT

Fortran program to interpolate MPAS data to structured grids
GNU General Public License v3.0
7 stars 13 forks source link

Several changes and updates #10

Closed ywangwof closed 5 months ago

ywangwof commented 11 months ago

  1. Trimmed some files with Fortran pretty formatter.

    You can compare the changes with the original files by ignoring white spaces with option diff --ignore-space-change. You can decide whether to accept this change or not.

  2. Added/updated support on Vecna with Intel classic suite and Openmpi.

  3. Merged with branch _feature/vertex_var_ for processing variable vorticity.

  4. Added variable PB and some global attributes in the output file for directly processing it using WoF-post. Note that variable P will be all zeros and PB is the total pressure.

LarissaReames-NOAA commented 10 months ago

Can we separate out the actual changes from the formatting changes? I'm not opposed to making the formatting look nicer, it's just hard to track the actual changes in the file comparisons to see what's actually been changed in a substantial manner.

ywangwof commented 10 months ago

It will be easier to do comparison if you use option "ignore all white space" “diff -b”. You can also use xxdiff installed here, /home/yunheng.wang/bin/xxdiff http://yunheng.wang/bin/xxdiff and choose option “ignore white space”.

Yunheng.

On Nov 8, 2023, at 1:57 PM, Larissa Reames @.***> wrote:

Can we separate out the actual changes from the formatting changes? I'm not opposed to making the formatting look nicer, it's just hard to track the actual changes in the file comparisons to see what's actually been changed in a substantial manner.

— Reply to this email directly, view it on GitHub https://github.com/LarissaReames-NOAA/MPASSIT/pull/10#issuecomment-1802560094, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNOCIJZOMUGAMAHTROEHLLYDPP3XAVCNFSM6AAAAAA56ASJYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGU3DAMBZGQ. You are receiving this because you authored the thread.

LarissaReames-NOAA commented 10 months ago

So because I merged the previous PR (#8) that provided the grid-edge interpolation, your PR now has a ton of conflicts with all of the formatting changes that would be pretty hard to fix. Can you just pull out the actual code changes you made and submit those in a separate PR from the formatting changes? That's gonna be the easiest path forward and will make it easier to track what was changed when from the git log file.

ywangwof commented 5 months ago

Since we merged PR #11, this one is not necessary. So I will close it.