Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[FEATURE] Make custom status condition icons darker on sheet #106

Open maxobremer opened 1 month ago

maxobremer commented 1 month ago

Describe your idea At the moment if you add an svg as the icon for a new condition then it can be hard to see that icon on your sheet. It would be nice if the white of those svg icons was made darker. DnD already does it for its own condition icons which are normally white (or atleast the icons in systems/dnd5e/icons/svg/statuses are) image

I will say this isnt much of an issue if it uses an svg associated with an existing condition (it kinda fixes itself if you toggle the status condition on and of on a sheet), but is an issue if the svg is from the folder icons/svg like for example icons/svg/stoned.svg which is the icon set up for the dazed condition in the image above

Versions

Additional context Any additional context.

Larkinabout commented 1 month ago

You'll need to edit the svg file to add the style fill rule used by the dnd5e system. Then it'll automatically pick up the dnd5e colour choice. Open up one of the dnd5e svgs in a text editor and you'll see what to copy and paste into your own.

Larkinabout commented 1 month ago

I'll add a note in the Conditions journal page to describe how to do it as if you don't know you'll waste a lot of time wondering why it seems to work fine for the dnd5e icons. It's the same when using svgs for other icons where they don't respect the sizing.

maxobremer commented 1 month ago

a journal entry would be nice, but wouldnt that also be undone every time foundry gets an update? I guess making a local edited copy would be the best or asking the foundry devs to edit the base svg

Larkinabout commented 1 month ago

Sorry, misunderstood what svg you were using. Yes, it'd be overwritten, so I'd probably take a copy and put it in your user data. I'm not sure where else that svg might be used, so it's possible the change to the style fill would not be feasible for the dnd5e system team to do.