search

Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[BUG] Configure Skills Not Working Properly #107

Closed pwykersotz closed 1 month ago

pwykersotz commented 1 month ago

Configure skills is no longer working (custom-dnd5e and lib wrapper are the only modules enabled)

Name changes function, but altered skills no longer sort alphabetically by name. image image

New skills do not display despite being enabled. image image

Ability changes to skills do not propagate to character sheet. image image

Module Data custom-dnd5e.json

No errors appear to be generated.

Versions:

Larkinabout commented 1 month ago

Name changes function, but altered skills no longer sort alphabetically by name.

The order on the character sheet is determined by the order in the Configure Skills list. As far as I remember, it's always been this way, unless dnd5e was doing it's own sorting.

New skills do not display despite being enabled.

This one is a bug and I'll fix it for the next release. It's happened because I moved when the abilities and skills configs are updated.

Ability changes to skills do not propagate to character sheet.

It looks like something has changed with the dnd5e system as it now stores each skills ability against the actor and uses that instead. It means setting it in the config no longer does anything for existing actors. Creating new actors does show the correct skill ability based on the config. I'll probably need to add a macro to allow users to overwrite every actors skills abilities with the ones from the config. Fun!

pwykersotz commented 1 month ago

The order on the character sheet is determined by the order in the Configure Skills list. As far as I remember, it's always been this way, unless dnd5e was doing it's own sorting.

Huh, you're right. I somehow it was auto sorting on previous versions (before 4.0), but if I manually move it, it's just fine. Thanks!

And thanks for the update and continued support. This module is fantastic.