Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[FEATURE] Integration with Cauldron of Plentiful Resources 'temporary effects hud' #134

Open Opius134 opened 2 weeks ago

Opius134 commented 2 weeks ago

Describe your idea The Cauldron of Plentiful Resources module has an option to add temporary active effects to the conditions hud. image image This feature replaces the old "Temporary Effects as Token Statuses" module which got phased out a while back. CustomDnD5e is almost completely compatible, except it kicks out an error when toggling these temporary status effects off. image The error doesn't affect much, but there does suggest incompatibility between cauldron's temp status feature and CustomDnD's "Toggle Status Effects on Selected" function.

Currently CustomDnD already interacts with these temporary statuses to some extent, as the radial status option displays them properly. image Attempting to remove a temporary status from multiple tokens at once fails, resulting in the status being removed from only one of the tokens. it also kicks out the error mentioned above. Is it possible to make the Toggle Status Effects on Selected function recognize and work with them too?

Versions

Additional context Before the dnd 3.0 jump, my installation made use of the Multi Token Status and Temporary Effects as Token Statuses modules. This pair of modules worked in tandem with little issue. Currently CustomDnD and Cauldron replace these features, and for the most part they play nice together.

If compatibility between the two is implemented, I'm hoping that it can be backported to dnd5e 3.3.1 as I've yet to make the jump. Hopefully it's a matter of finding the temporary status' id?

Larkinabout commented 2 weeks ago

I've had a look but I've not been able to get any errors either when adding/removing effects for all selected tokens or when switching temporary effects off from the HUD. Will you please reproduce the steps to produce the error please.

Opius134 commented 2 weeks ago

Sorry for the delay!

(I've disabled all modules save for custom dnd, CPR, and their dependencies)

Method 1: Create a new effect in the effects sidebar (CPR feature), give it an effect duration. image Highlight two or more tokens, click the new effect to apply it to both actors. image With both actors highlighted, right click and bring up the token hud, then click the effect to remove it. image In my installation, it only removes the temporary effect from one of the tokens. image And kicks out the error. image

Method 2: Use any spell that can apply an effect to an actor. In this case, slow image Apply the effect to a token through the item card, repeat the process of removing the temporary effect. image

Additional note: Applying the temporary effect from the chat card causes the error to appear twice on application (twice, in fact), rather than when attempting to remove.

With either method, the effect is successfully applied, but you can't remove the effects from all tokens simultaneously.