Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[BUG] Encumbered Condition Doesn't Account for Weight Modifiers #53

Closed aprusik closed 5 months ago

aprusik commented 6 months ago

Describe the bug The weight modifiers only seem to affect the visual encumbrance on the sheet, and not whatever is tracked for applying/unapplying the encumbered condition.

In the screenshot below, I have equipped items set to reduce their weight to 0. You can see the character sheet shows I am below the first encumbrance level as the hempen rope is equipped, but I am still encumbered: image

If I unequip the hempen rope, the carry weight goes above the first threshold where I would expect to be encumbered: image

If I instead remove the hempen rope, the visual weight stays the same (because it should have been reduced to zero by the modifier) but the encumbrance effect goes away (note the carry weight is the same as screenshot 1) image

Module Data New world, no other modules installed

custom-dnd5e.json

Steps to reproduce

  1. Set Weight Modifiers to 0
  2. Set Encumbrance to "Variant Rules" in the System Settings
  3. Go to a character sheet that is barely encumbered
  4. Equip something that weighs more than the difference between your weight and the first weight threshold.
  5. See error

Versions:

Larkinabout commented 5 months ago

Fixed in 0.12.0.