search

Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[BUG] Radial Status Effects confilcts with Monk's Bloodspats #56

Closed TrofimSelbs closed 5 months ago

TrofimSelbs commented 5 months ago

Describe the bug

Enabling "Radial Status Effects' in module's settings shows libwrapper's error. Error: libWrapper module Monks Bloodsplats and module Custom D&D Se modify the same Foundryar functionality and are more likely to conflict. (see console) image image

Module Data custom-dnd5e.json

Steps to reproduce

  1. Enable Monk's bloodspats
  2. Enable Custom D&D
  3. In Custom D&D go to the bottom of the settings and allow Radial status effects
  4. Reload the game Result: a yellow warning from libwrapper shows up. Haven't seen any real consequences other than this error. But they may be

Versions:

Additional context Not sure if this issue should be addressed to this module or Monk's Bloodpats, as two conflict. I will make an issue thread in both places.

Larkinabout commented 5 months ago

I believe libWrapper has the option to give a module priority, I don't know whether that'll stop the warning message. In either case, it's probably just advising that that there are two modules wrapping the same function even if they don't conflict with each other.

TrofimSelbs commented 5 months ago

Tried and it doesn't remove the message for me, unfortunately

Larkinabout commented 5 months ago

It looks like it's ultimately because Monk's Bloodsplats is using a MIXED wrapper to stop the dead status effect overlay from applying for NPCs. libWrapper is warning about potential conflicts because Monk's patch would stop other patched code from running when they occur after. Not sure if there's a different way to hide the overlay, but it would be for Monk to look into.

TrofimSelbs commented 5 months ago

Got it. I created an issue thread on monks as well, so we’ll see. Thank you!