search

Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[BUG] Character Sheet Breaks When Using Variant Encumberance #58

Closed aprusik closed 5 months ago

aprusik commented 5 months ago

Describe the bug

Attempting to open a player character sheet with Variant Encumbrance enabled in the system settings results in the character sheet failing to open and an error being sent to the console.

Module Data

custom-dnd5e.json

Steps to reproduce

  1. Import a Player Character (I use Zanna)
  2. Enable Variant Encumbrance in the system settings
  3. Attempt to equip/uneqip an item
  4. See error - sheet becomes unresponsive
  5. Close and attempt to reopen sheet
  6. See error - sheet won't open

Versions:

Additional context Errors on attempting to open character sheet:

Error 1 ``` TypeError: An error occurred while rendering ActorSheet5eCharacter2 40. attributes.encumbrance is undefined [Detected 3 packages: system:dnd5e, custom-dnd5e, lib-wrapper] getData character-sheet-2.mjs:310 renderPatch application-render.js:28 call_wrapper libWrapper-wrapper.js:591 _render#0 libWrapper-wrapper.js:189 _render foundry.js:6532 _render character-sheet-2.mjs:184 render foundry.js:5769 render foundry.js:7111 _onClickLeft2 foundry.js:56272 callback foundry.js:31766 #handleClickLeft2 foundry.js:31971 #handleMouseDown foundry.js:31938 notifyListeners earcut.js:128 notifyTarget earcut.js:128 propagate earcut.js:128 dispatchEvent earcut.js:128 mapPointerDown earcut.js:128 mapEvent earcut.js:128 onPointerDown earcut.js:128 addEvents earcut.js:128 setTargetElement earcut.js:128 init earcut.js:128 emit index.mjs:5 run index.js:89 un index.js:126 wa index.js:89 xn earcut.js:128 #createApplication foundry.js:26327 initialize foundry.js:26223 initializeCanvas foundry.js:8894 setupGame foundry.js:8724 _initializeGameView foundry.js:9990 _initializeView foundry.js:9966 initialize foundry.js:8650 call_wrapped libWrapper-wrapper.js:507 libWrapperInit libWrapper-api.js:805 initialize#0 libWrapper-wrapper.js:187 foundry.js:91833 async* foundry.js:91809 [foundry.js:753:30](https://foundry.aprusik.com/scripts/foundry.js) onError foundry.js:753 call_wrapped libWrapper-wrapper.js:507 listeners.js:138 onError#0 libWrapper-wrapper.js:187 render foundry.js:5771 (Async: promise callback) render foundry.js:5769 render foundry.js:7111 _onClickLeft2 foundry.js:56272 callback foundry.js:31766 #handleClickLeft2 foundry.js:31971 #handleMouseDown foundry.js:31938 notifyListeners earcut.js:128 notifyTarget earcut.js:128 propagate earcut.js:128 dispatchEvent earcut.js:128 mapPointerDown earcut.js:128 mapEvent earcut.js:128 onPointerDown earcut.js:128 (Async: EventListener.handleEvent) addEvents earcut.js:128 setTargetElement earcut.js:128 init earcut.js:128 emit index.mjs:5 run index.js:89 un index.js:126 wa index.js:89 xn earcut.js:128 #createApplication foundry.js:26327 initialize foundry.js:26223 initializeCanvas foundry.js:8894 setupGame foundry.js:8724 _initializeGameView foundry.js:9990 _initializeView foundry.js:9966 initialize foundry.js:8650 call_wrapped libWrapper-wrapper.js:507 libWrapperInit libWrapper-api.js:805 initialize#0 libWrapper-wrapper.js:187 foundry.js:91833 foundry.js:91809 ```
Error 2 ``` Error: An error occurred while rendering ActorSheet5eCharacter2 40. One of original or other are not Objects! [Detected 3 packages: custom-dnd5e, lib-wrapper, system:dnd5e] mergeObject commons.js:2739 _mergeUpdate commons.js:2803 mergeObject commons.js:2760 _mergeUpdate commons.js:2803 mergeObject commons.js:2760 _mergeUpdate commons.js:2803 mergeObject commons.js:2760 renderPatch application-render.js:23 call_wrapper libWrapper-wrapper.js:591 _render#0 libWrapper-wrapper.js:189 _render foundry.js:6532 _render character-sheet-2.mjs:184 render foundry.js:5769 render foundry.js:7111 _onClickLeft2 foundry.js:56272 callback foundry.js:31766 #handleClickLeft2 foundry.js:31971 #handleMouseDown foundry.js:31938 notifyListeners earcut.js:128 notifyTarget earcut.js:128 propagate earcut.js:128 dispatchEvent earcut.js:128 mapPointerDown earcut.js:128 mapEvent earcut.js:128 onPointerDown earcut.js:128 addEvents earcut.js:128 setTargetElement earcut.js:128 init earcut.js:128 emit index.mjs:5 run index.js:89 un index.js:126 wa index.js:89 xn earcut.js:128 #createApplication foundry.js:26327 initialize foundry.js:26223 initializeCanvas foundry.js:8894 setupGame foundry.js:8724 _initializeGameView foundry.js:9990 _initializeView foundry.js:9966 initialize foundry.js:8650 call_wrapped libWrapper-wrapper.js:507 libWrapperInit libWrapper-api.js:805 initialize#0 libWrapper-wrapper.js:187 foundry.js:91833 async* foundry.js:91809 [foundry.js:753:30](https://foundry.aprusik.com/scripts/foundry.js) onError foundry.js:753 call_wrapped libWrapper-wrapper.js:507 listeners.js:138 onError#0 libWrapper-wrapper.js:187 render foundry.js:5771 (Async: promise callback) render foundry.js:5769 render foundry.js:7111 _onClickLeft2 foundry.js:56272 callback foundry.js:31766 #handleClickLeft2 foundry.js:31971 #handleMouseDown foundry.js:31938 notifyListeners earcut.js:128 notifyTarget earcut.js:128 propagate earcut.js:128 dispatchEvent earcut.js:128 mapPointerDown earcut.js:128 mapEvent earcut.js:128 onPointerDown earcut.js:128 (Async: EventListener.handleEvent) addEvents earcut.js:128 setTargetElement earcut.js:128 init earcut.js:128 emit index.mjs:5 run index.js:89 un index.js:126 wa index.js:89 xn earcut.js:128 #createApplication foundry.js:26327 initialize foundry.js:26223 initializeCanvas foundry.js:8894 setupGame foundry.js:8724 _initializeGameView foundry.js:9990 _initializeView foundry.js:9966 initialize foundry.js:8650 call_wrapped libWrapper-wrapper.js:507 libWrapperInit libWrapper-api.js:805 initialize#0 libWrapper-wrapper.js:187 foundry.js:91833 foundry.js:91809 ```
Larkinabout commented 5 months ago

Fixed in 0.12.2.