Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

Custom sheet doesn't play nicely with Resources+ [COMPATIBILITY] #73

Closed Opius134 closed 2 months ago

Opius134 commented 2 months ago

Describe the bug

As of right now the Custom sheet has some errors when using the Resources Plus module (https://github.com/ardittristan/5eSheet-resourcesPlus). The resources are presented as favorites, cannot be edited, and cannot be reduced to 0 locally.

Normal behavior from DnD5e 3.0+ sheet image image

Behavior from Custom sheet image image image

Module Data

custom-dnd5e.json

Steps to reproduce 1.Enable both Resources Plus and Custom Dnd5e 2.Change the player actor character sheet type to custom dnd5e 3.The favorites section now has uneditable resources which cannot be hidden by adjusting the setting to 0 resources.

Versions:

Larkinabout commented 2 months ago

My immediate thought is that Resources Plus module just needs to account for the custom sheet's name. The custom sheet is just a slight rejig of the official one, so it'll probably work with all the existing code for the official sheet.

Opius134 commented 2 months ago

I'll put a bug report over there in that case, thanks for the insight!