Larkinabout / fvtt-custom-dnd5e

11 stars 7 forks source link

[BUG] When applying prone, unconscious or death to a token Warning pop up only for players #91

Closed Dynsai closed 4 days ago

Dynsai commented 2 weeks ago

Describe the bug

image When I apply to a token the status prone, death or unconscious and this warning pop up. This occurs to any token the player doesn't own. There are 3 warnings pop ups. If i remove the values on "Rotation" and "Tint" on Dead category and Prone category on the settings configuration of the module the pop up warnings are reduced to 1 instead of 3.

Module Data

Go into the module's settings, open up the Debug Settings menu, click Export Data, save and attach the file here. custom-dnd5e.json

Steps to reproduce

  1. Go to a token
  2. Click on death, prone or unconscious status
  3. Players will se a pop up warning

Versions:

Additional context When i start the world there is an alert about incompatibility with monk's Bloodsplats. I disable it but the error persist.

Example of the warning on the console:

User Y - Raúl lacks permission to update Token [UQcPMFOt3Jia3R79] in parent Scene [zxDGecQ8sZD9TBe5]
fetch   @   foundry.js:71791
_remove @   foundry.js:71775
(anonymous) @   foundry.js:71794
setTimeout      
fetch   @   foundry.js:71794
notify  @   foundry.js:71687
🎁call_wrapped   @   libWrapper-wrapper.js:507
_lw_ui_notifications_notify @   Bundle.js:132169
🎁call_wrapper   @   libWrapper-wrapper.js:616
🎁ui.notifications.notify#0  @   libWrapper-wrapper.js:189
error   @   foundry.js:71724
#handleError    @   foundry.js:3454
(anonymous) @   foundry.js:3437
value   @   socket.js:580
value   @   socket.js:499
U.emit  @   index.mjs:136
(anonymous) @   manager.js:204
Promise.then        
ce  @   websocket-constructor.browser.js:5
value   @   manager.js:203
U.emit  @   index.mjs:136
value   @   index.js:146
value   @   manager.js:190
U.emit  @   index.mjs:136
value   @   socket.js:341
U.emit  @   index.mjs:136
value   @   transport.js:98
value   @   transport.js:90
ws.onmessage    @   websocket.js:68

I tried a lot of things (4 hours trying), other modules, libwrapper settings, checking the code (i have very limited knowledge of js) but i couldn't find anything. Any help is appreciate. Thanks!

Larkinabout commented 2 weeks ago

Does the token still rotate/tint? I expect I just need to check that the user trying to apply the properties are the GM or owner.

Dynsai commented 2 weeks ago

Yes, the token still rotate and tint without any problem. All the players are able to see the tint and rotation.

DragonHale commented 5 days ago

Hi I'm having the exact same issue. My players brought this to my attention yesterday.

Bobster96Lobster commented 4 days ago

Hello having the same issue here. It doesn't break anything but is annoying enough to turn off the module for my players.

Larkinabout commented 4 days ago

Fixed in 0.15.0.