search

Larkinabout / fvtt-token-action-hud-core

Token Action HUD is a repositionable HUD of actions for a selected token.
13 stars 18 forks source link

[BUG] could not get initial migrate of flags to work unless file browse and upload permissions granted #120

Closed modzy2 closed 1 year ago

modzy2 commented 1 year ago

Describe the bug I could not get fresh logons of users to get the "successfully migrated flags" to happen (and creation of their json in the users folder) unless I provided file browse and upload permissions to "players" first. Without that their hud would not show up. This happened even though I had a GM logged in always. Is the file browse/upload permission an ongoing requirement to allow users to continue to manage their settings, or can I drop that permission again once the users folder is populated for each player?

Versions:

Larkinabout commented 1 year ago

It shouldn't as the functions to to save data are executed through socketlib using the executeAsGM method. I'll run some tests to see if there's an issue.

farling42 commented 1 year ago

It sounds like maybe the initial directory creation isn't being done by the GM?

A report of discord says that user needs file creation permissions to get it working in the first place, but they can be disabled afterwards.

Larkinabout commented 1 year ago

Yes, it's the initial migration from 1.3 to 1.4 that is failing. You're correct that that part isn't being passed through the socket to execute as the GM.

Larkinabout commented 1 year ago

Fixed in Token Action HUD Core 1.4.3.