search

Larkinabout / fvtt-token-action-hud-pf2e

Token Action HUD is a repositionable HUD of actions for a selected token.
10 stars 15 forks source link

Missing Toggles for various abilities #125

Open Peach774 opened 8 months ago

Peach774 commented 8 months ago

My players do not have toggles for monastic archer stance or their finishers. My swashbuckler player only has 1 finisher, so they can't change types, but they dont even have an option under strikes to toggle it. The same goes for the monk with monastic archer stance. I have tried removing and re-adding these abilities and it doesn't seem to fix it.

Silvertower commented 8 months ago

For toggles to appear in Token Action HUD, the action in question must have a Roll Option rule element. Most, if not all, stances in PF2e's system are implemented using Self-Applied Effects. In this case, if you want to use the HUD, you should go to the Actions tab in the HUD, then click on the stance to link it to chat, and then click on the Apply Effect button in chat.

While it would be nice to have the HUD automatically apply effects implemented this way, that would be a feature request and might be out of scope for now.

Peach774 commented 8 months ago

For toggles to appear in Token Action HUD, the action in question must have a Roll Option rule element. Most, if not all, stances in PF2e's system are implemented using Self-Applied Effects. In this case, if you want to use the HUD, you should go to the Actions tab in the HUD, then click on the stance to link it to chat, and then click on the Apply Effect button in chat.

While it would be nice to have the HUD automatically apply effects implemented this way, that would be a feature request and might be out of scope for now.

What about the swashbuckler finisher?

Silvertower commented 8 months ago

Honestly, I am not sure how Finishers are implemented. A cursory look doesn't reveal how Finisher and the associated drop-down on the character sheet Actions page are added. If you, or someone else, can locate the code, we can look into whether this can be added to the HUD. But as it is, Finisher is not a traditional toggle, and so the HUD doesn't see it.

Peach774 commented 8 months ago

Honestly, I am not sure how Finishers are implemented. A cursory look doesn't reveal how Finisher and the associated drop-down on the character sheet Actions page are added. If you, or someone else, can locate the code, we can look into whether this can be added to the HUD. But as it is, Finisher is not a traditional toggle, and so the HUD doesn't see it.

image image It appears to be a rule element at least partially?

Silvertower commented 8 months ago

It is, but that is simply a Note that is added to the chat.

Silvertower commented 8 months ago

I will have to find some time to review the PF2e system's code for how Finishers are added to the character sheet. It may be something hard-coded specifically for Swashbucklers.

Peach774 commented 8 months ago

I will have to find some time to review the PF2e system's code for how Finishers are added to the character sheet. It may be something hard-coded specifically for Swashbucklers.

It worked in the past, so im more confused on why it isnt working anymore

Silvertower commented 8 months ago

Can you provide a list of PF2e system version and Token Action HUD version where it worked?

Peach774 commented 8 months ago

Can you provide a list of PF2e system version and Token Action HUD version where it worked?

pre-remaster for sure, not sure after that

Silvertower commented 8 months ago

I will check it out when I have time. My guess is that there has been a fundamental design change with the PF2e system since then.

Silvertower commented 8 months ago

It is not obvious to me at this time as to how Finishers are handled on the PF2e character sheet. There is some black magic going on.

tehguitarist commented 8 months ago

If it helps, here were a couple of recent PR's in the system for finishers:

https://github.com/foundryvtt/pf2e/pull/13061 https://github.com/foundryvtt/pf2e/pull/9473

pedrogrullada commented 7 months ago

It is not obvious to me at this time as to how Finishers are handled on the PF2e character sheet. There is some black magic going on.

The finisher toggles are in a Roll Option in the precise strike class feature, with each suboption being predicated on their corresponding feats. This might change soon as dynamic suboptions can let us tidy it up a bit, like having each feat add their suboption to the list, but for now this is where they live.

Silvertower commented 7 months ago

Good to know. Parsing RE's is out of scope for for me. If someone wants to make a pull request, we can consider merging it.

WaldysCZ commented 5 months ago

I would like to add, that i no longer see any toggles in hud on NPCs, I'm pretty sure they were there before remaster. For example Bandit Lieutenant's Single Out or Goblin Pyro's "Torch is lit".

Silvertower commented 5 months ago

@WaldysCZ Thanks for the report. This will be fixed in the next release. This is unrelated to the originally reported issue, however.