search

Larkinabout / fvtt-token-action-hud-pf2e

Token Action HUD is a repositionable HUD of actions for a selected token.
10 stars 15 forks source link

Perception Numbers Don't Match #142

Closed Bryan-Legend closed 3 months ago

Bryan-Legend commented 3 months ago
Screenshot 2024-05-02 203041

Screenshot 2024-05-02 203209

The Perception roll on the action hud is not including item or circumstance modifiers.

Silvertower commented 3 months ago

Thank you for the report. This is caused by a limitation in what PF2E System reports using the actor's perception tooltip data. There are actually multiple different things going on here.

  1. The "Eye Slash" bonus at the bottom of the second screenshot is a manually added bonus, and is not provided by the item. You can tell by the X in a circle icon to the right of it. While this manual bonus is always in effect for Perception rolls, it is not returned by the actor's perception tooltip data, which is what Token Action HUD uses. I will see about adding logic to pick up manual bonuses, assuming I can find where they are stored on the actor's data.
  2. Battlefield Surveyor and Incredible Initiative (and other +perception on initiative feats) also do not appear in the perception tooltip data, and logic to pick these up will need to be added.
  3. Only bonuses that are set to "enabled" are shown in the tooltip, as this is the only thing Token Action HUD can be "sure of" when the tooltip is being built. So, "Eye Slash (Major)" and "Incredible Initiative" won't show up in the tooltip data that Token Action HUD shows, since they can only be enabled via the roll dialog when an actual roll is being made. While it would be possible to show them in the tooltip with a note that they are disabled, this just clutters the tooltip, so I think the current behavior of not showing them is correct.
Silvertower commented 3 months ago

Luckily, this was an easier fix than expected. PF2E System provides an actor.initiative dataset, which works as a direct substitution for actor.perception (which Token Action HUD was using previously) and picks up the tooltip data without any further logic changes required.

This issue will be fixed in the next release of Token Action HUD 2E.

Bryan-Legend commented 3 months ago

Thank you.

Are there any other numbers that could be out of sync still? I'm mistrustful now that I played a dozen sessions using the wrong init.

On Fri, May 10, 2024 at 10:10 AM Alan Miles @.***> wrote:

Closed #142 https://github.com/Larkinabout/fvtt-token-action-hud-pf2e/issues/142 as completed via 021fb50 https://github.com/Larkinabout/fvtt-token-action-hud-pf2e/commit/021fb5000bb2b700dc419b70cf4c69960026efac .

— Reply to this email directly, view it on GitHub https://github.com/Larkinabout/fvtt-token-action-hud-pf2e/issues/142#event-12771561433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHAUOE5TTE3ACRDXFCDXLTZBTWOLAVCNFSM6AAAAABHGP25FOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43TCNJWGE2DGMY . You are receiving this because you authored the thread.Message ID: <Larkinabout/fvtt-token-action-hud-pf2e/issue/142/issue_event/12771561433@ github.com>

Silvertower commented 3 months ago

I do not know. But feel free to report any you find.