Larkinabout / fvtt-token-action-hud-pf2e

Token Action HUD is a repositionable HUD of actions for a selected token.
10 stars 15 forks source link

HUD Core Compatibiltiy #151

Closed Keatnisher closed 1 month ago

Keatnisher commented 1 month ago

Hi, I'm receiving the banner error message to "update" my Token Action HUD Core module to 1.5.5 in order for HUD PF2e to work - but my Core module is actually ahead at 1.5.6. Can this be fixed to check for at least version 1.5.5?

Also, this appears to make HUD PF2e to not display - unless this is related to another issue.

Silvertower commented 1 month ago

Hello. I don't know what that means, unfortunately. TAH2E doesn't produce banner messages itself.

Keatnisher commented 1 month ago

Oh, my bad - this is the error I'm receiving:

image

Silvertower commented 1 month ago

This looks like a message from Token Action HUD Core. I will see if I can fix it.

Larkinabout commented 1 month ago

It means the system module is set to require a specific version of Token Action HUD Core.

Best bet is to set the required version to 1.5 rather than 1.5.X as the X releases are not intended to include breaking changes for system modules and X.X releases are much rarer.

Silvertower commented 1 month ago

Cool. I know nothing about this stuff.

Keatnisher commented 1 month ago

Is it as simple as removing the maximum of 1.5 here in module.json? Or is a set max required?

"requires": [ { "id": "token-action-hud-core", "type": "module", "compatibility": [ { "minimum": "1.5.5", "maximum": "1.5", "verified": "1.5.5" } ] }

Larkinabout commented 1 month ago

Yeah, I wouldnt have expected it. It's mentioned here for those developing a system module from scratch: https://github.com/Larkinabout/fvtt-token-action-hud-core/wiki/Developing-a-System-Module#requiredcoremoduleversion

Larkinabout commented 1 month ago

Is it as simple as removing the maximum of 1.5 here in module.json? Or is a set max required?

"requires": [ { "id": "token-action-hud-core", "type": "module", "compatibility": [ { "minimum": "1.5.5", "maximum": "1.5", "verified": "1.5.5" } ] }

No, but @Silvertower is on it, so you can just download the release when it happens.

Silvertower commented 1 month ago

Fixed in Token Action HUD PF2E version 1.5.17.

Keatnisher commented 1 month ago

Everything's working now! Thanks for the quick response :)