Larkinabout / fvtt-token-action-hud-pf2e

Token Action HUD is a repositionable HUD of actions for a selected token.
10 stars 15 forks source link

Matching the one-line per weapon mode for PF2 Strikes #29

Closed apoapostolov closed 1 year ago

apoapostolov commented 1 year ago

@Larkinabout This has been discussed multiple times and is preventing me from moving my games to the new Core. Can we talk about paid commission for options allowing to replicate the same order of buttons with a few minor improvements over the legacy?

Please let me know (you can find me on Discord ApoApostolov#4622)

Larkinabout commented 1 year ago

Like this?: image

This is just an example done in the existing version by moving the actions around. I'll look at adding a module setting to default strikes to a single line, but I can't make guarantees about when I'll get to look at it. Sorry, I'm not interested in paid commissions as I'm just doing this in my spare time and money sets expectations. Thanks for the offer though.

apoapostolov commented 1 year ago

This looks great for a start. Few suggestions that would improve it.

One additional thing that would really help with the vertical alignment is to add support in core for moving the name of a section before the row of buttons right aligned, like in old Legacy TAH, as this would allow weapons to fit next to each other vertically with no loss of space (especially for fighters with 6+ weapons which is very normal experience mid-tier).

uniwars commented 1 year ago

"One additional thing that would really help with the vertical alignment is to add support in core for moving the name of a section before the row of buttons right aligned, like in old Legacy TAH, as this would allow weapons to fit next to each other vertically with no loss of space (especially for fighters with 6+ weapons which is very normal experience mid-tier)." +1 it can helps to gain space for spells, actions, feats as well, as an option of sorting

apoapostolov commented 1 year ago

Based on my last feedback above, my proposal for weapon strikes would become.

Alternatively, option to not show the weapon name subsection but to change them to hover label.

Larkinabout commented 1 year ago

Larkinabout/fvtt-token-action-hud-core#99

apoapostolov commented 1 year ago

@Larkinabout No pressure from my side to deliver, but can you comment on my post above summarizing the changes needed to replicate the OG TAH style? Just want to know if we agree on the changes needed, or my proposal is not working for you.

Larkinabout commented 1 year ago

@apoapostolov, only issue is actually achieving what is proposed, not with what is proposed itself. Although it may not seem like much, each element amounts to a significant rework. It's not off the table, but I don't have a quick fix, so it's likely to stay as is until I get some inspiration or someone else solves it. Meanwhile, there are a bunch of new customisation features that should make life easier.

Larkinabout commented 1 year ago

Token Action HUD Pathfinder 2 1.4.3 adds images for strike groups and a module setting to hide strikes names by default. image

apoapostolov commented 1 year ago

Thank you. This is very close to perfect, not the same thing technically but if the players sheath their weapons it reverts to one line so it is close to perfect. I think it is good to stay, and thank you again for all the hard work getting here. The only pet peeve remains the Thrown category, if that can be fixed somehow #53 then I have no reasons to not migrate.

Larkinabout commented 1 year ago

Closing as resolved.

Zullock commented 1 year ago

@apoapostolov created a PR with some of those changes: https://github.com/Larkinabout/fvtt-token-action-hud-pf2e/pull/67

apoapostolov commented 1 year ago

Thanks, this is looking very polished now.