Larkinabout / fvtt-token-action-hud-pf2e

Token Action HUD is a repositionable HUD of actions for a selected token.
10 stars 15 forks source link

Not compatible with system version 5.9.1 #98

Closed luque-gh closed 9 months ago

luque-gh commented 10 months ago

Action bar is not rendering and there is an error in console:

image

lunahoshii commented 10 months ago

same problem 5.9.1 - my char is lvl 2 fetchling champion if that helps image

lunahoshii commented 10 months ago

some other characters work, like for example my player's tengu alchemist, but it takes like ~5 seconds for quick bar to render after you select token

lunahoshii commented 10 months ago

update: i tried re-creating my character, and I think i know what breaks it basically, quick action hud renders fine just until the point you add ANY spell into your prepared spells for example here I've added just Guidance into my skillbook of champion and it instantly stopped rendering quick hud I've also tested this with our Wizard - the moment you add any spell into prepared spells it breaks, so, yeah, hope it helps! image

lunahoshii commented 10 months ago

Also sorry for many messages - we've tried with alchemy and it looks like it works fine, adding new formulas into crafting list doesn't break anything, crafting from reagents also works - so atleast this works!

devinus commented 10 months ago

@lunahoshii the HUD works for the rogue and fighter but not the cleric of wizard in our campaign, so that tracks.

kjgonzalez commented 10 months ago

wanted to add a little more:

gezero commented 9 months ago

Sorry, I am new here. I just started playing PF last week, so I don't know much about either PF or Foundry. I tried to debug the issue so that we can use the module in our group, and it looks like the problem is on this line (and also on the next one)

https://github.com/Larkinabout/fvtt-token-action-hud-pf2e/blob/b9005f32d9af4d379e622336553079300eeb417a/scripts/action-handler.js#L1835

the code expects that a spell has nonempty components, but neither the spell nor the system has any components field defined. For our internal group I replaced the returned values with empty strings and the action bar now loads and casters can use it.

As I don't know what components of a spell are or what they were I cannot suggest a fix or open a PR, but maybe someone here can explain it to me and I can fix it for everybody. Did perhaps the PF remaster remove components from spells ¯\(ツ)/¯?

the issues #99 and #100 seam to me to be just the same issue as the one discussed here.

gezero commented 9 months ago

Seams working for me, thanks

Larkinabout commented 9 months ago

Fixed in 1.5.3.

lunahoshii commented 9 months ago

As I don't know what components of a spell are or what they were I cannot suggest a fix or open a PR, but maybe someone here can explain it to me and I can fix it for everybody. Did perhaps the PF remaster remove components from spells ¯_(ツ)_/¯?

Hello! Sorry for late reply! But you were right about components being removed from remaster. If you're still interested, in legacy every spell had some component to it that you needed to fulfill in order to cast a spell for example some spells had "Verbal" component - which means that it's required to shout out a spell loudly in order to cast it (if you're silenced and can't talk - you can't cast verbal spells)

More on it: https://2e.aonprd.com/Rules.aspx?ID=281