LarryRuane / bitcoin

Bitcore Bitcoin build with address indexes
https://bitcore.io/bitcoin
MIT License
0 stars 0 forks source link

log RPC arguments for testnets #2

Open LarryRuane opened 1 year ago

LarryRuane commented 1 year ago

This PR https://github.com/bitcoin/bitcoin/pull/16365 attempted to log only non-secret RPC arguments for all networks (including mainnet), and that turned out to be difficult, and therefore not a popular idea. But logging them for just the testnets (testnet, signet) would be very useful, especially for understanding why tests are failing (or how they work).

So probably create a new PR that does that (would be quite a bit different, so probably best not to resurrect this closed PR).