search

LarsWiegers / laravel-maps

Your laravel maps libary.
https://github.com/LarsWiegers/laravel-maps
MIT License
254 stars 35 forks source link

Added Custom InfoWindow and Icon on Google Maps #24

Closed kikojover closed 2 years ago

kikojover commented 2 years ago

Hi Lars, this is a great package!! In one of my projects i need InfoWindow and custom icons on Google Map. I've added this ability to blade template. Hope is useful and you accept PR Thanks for your work

LarsWiegers commented 2 years ago

Hi @kikojover, thx for the kind words!

Love the idea and the pr. Do you use the package only for google maps?

I would love to keep the api for both the map types ( google map and leaflet ) the same.

If you add tests for the google maps info window, I can add the version for leaflet + tests.

Sounds like a deal?

kikojover commented 2 years ago

Sure it's a deal!! :-) Only let me use a couple of days to add the tests, sorry, I'm a newbie in the PR World.

About your question, it's the first time I have used your package, my current project requires Google Maps, so the answer is yes, i use your package only for Google Maps (for the moment ;-)), but I hope use leaflet too in he future.

A question about PR, i must send another PR with the tests or it's possible to include it in current one? (As you told I'm a newbie ...)

Thank you.

LarsWiegers commented 2 years ago

Hey, you can add the tests to this pr.

kikojover commented 2 years ago

Hi @LarsWiegers , i've added Unit tests to Google Maps :-)

LarsWiegers commented 2 years ago

@kikojover I have merged the changes + made a new release. Thank you for adding the new functionality and creating the pr.