search

LarsWiegers / laravel-maps

Your laravel maps libary.
https://github.com/LarsWiegers/laravel-maps
MIT License
254 stars 35 forks source link

clear up section about html escaping #39

Closed LarsWiegers closed 1 year ago

LarsWiegers commented 1 year ago

Make the section of the documentation ( readme for now) clearer on how HTML is not escaped and as such quotes will interfere with the resulting code. the double quotes character should not be used.

anushkabishnoi commented 1 year ago

Hello, this is my first experience with open source contributions. Would really appreciate it if you explained exactly what is needed to be done.

I would love to work on this issue.

Thanks in advance! :)

LarsWiegers commented 1 year ago

Hey! Awesome that you want to start with open source. This repository was my first way into open source to 😄

What needs to happen: Add a section to this part of the readme https://github.com/LarsWiegers/laravel-maps#usage which explains that double qoutes are not allowed ( if not escaped ) in the info box of the markers

LarsWiegers commented 1 year ago

fixed by #42. Thanks @anushkabishnoi 😄