search

Larswad / uno2iec

A commodore (CBM) 1541 emulator on the Arduino Uno, using any desktop PC (or raspberry PI with raspbian) as a media host.
http://larswad.github.io/uno2iec/
134 stars 36 forks source link

Adding a define to not reset the c64 as the ino reset #10

Closed biappi closed 9 years ago

biappi commented 9 years ago

this is just a small feature toggle. my c64 will reset if the line is held high, and i find it really annoying, especially when deploying new code to the arduino, or re-connecting the pc side client.

maybe others can find it useful too.

Larswad commented 9 years ago

Yes, you are right, I also read somewhere older 64's had a different behavior on the reset line. But I never had one to test with. I believe the sd2iec doesn't even care about the reset line at all and maybe there is no actual need. I kept it just as a way to know when the host computer reset, just in case I ever needed to reset some states or something.

I will merge your addition, but only partly, because what about those Log statements in your push, they were not really part of this right? It looks like you have used them for some debugging?

biappi commented 9 years ago

ooops, yeah totatlly debug logging… sorry i didn’t double check the diff i was sending :/

-w

On May 7, 2015, at 2:29 PM, Lars Wadefalk notifications@github.com wrote:

Yes, you are right, I also read somewhere older 64's had a different behavior on the reset line. But I never had one to test with. I believe the sd2iec doesn't even care about the reset line at all and maybe there is no actual need. I kept it just as a way to know when the host computer reset, just in case I ever needed to reset some states or something.

I will merge your addition, but only partly, because what about those Log statements in your push, they were not really part of this right? It looks like you have used them for some debugging?

— Reply to this email directly or view it on GitHub.

Larswad commented 9 years ago

No problem biappi! I wonder if github supports partial marging of a pull request.

biappi commented 9 years ago

i think me or you can add a commit on to of the pull-request branch to remove the logs. then merge from the github ui

On May 7, 2015, at 2:39 PM, Lars Wadefalk notifications@github.com wrote:

No problem biappi! I wonder if github supports partial marging of a pull request.

— Reply to this email directly or view it on GitHub.

Larswad commented 9 years ago

Hmm, It says i need to have push rights in order to make changes on that branch (which I don't...).

Larswad commented 9 years ago

That's it. Thanks.