search

LartTyler / MHWDB-API

Source code for the Monster Hunter World API project
GNU Affero General Public License v3.0
74 stars 11 forks source link

Add Safi' Jiiva Weapons and Siege #126

Open DeveloperPaul123 opened 4 years ago

DeveloperPaul123 commented 4 years ago

I wanted to open the discussion on how to add the Safi weapons. These may need some special treatment since their upgrade mechanics are a bit different than the other weapons.

Also it would be good to add the Safi' Jiiva siege to the event part of the API since this works similarly to the KT siege. Maybe this just requires updating the web scrapper that pulls event information?

LartTyler commented 4 years ago

I only have MHW on PC, so I don't really know much about how the Safi'Jiiva work. I'll do some digging, and get back to you on how best to support something like that.

As far as events go, none of the Iceborne events are currently in the API. The pages use the same HTML layout, so I should just be able to point the scraper at the new URL (with some minor tweaks to support new event types). I'll do some tinkering later today.

DeveloperPaul123 commented 4 years ago

I see, didn't realize you were on PC. Overall Safi'Jiiva works similar to ATKT except the reward pool is is not as large and there is less RNG. I can explain here but not sure how much you would want to avoid spoilers?

LartTyler commented 4 years ago

I don't mind spoilers, but it'd probably be easier for me to do some digging on Kiranico or one of the wikis. I'm going to get the Safi weapons added to the top of the backlog, after some of the easier stuff like adding the Iceborne events to the API.

DeveloperPaul123 commented 4 years ago

Ok sounds good.

Overall, each weapon has 9 variants. One for each element/status except for HBG and LBG. They all have the same starting stats + sharpness and similar element/status values. If you decide the weapons can just be added as all the other weapons I can add them to the API.

Other than that, the unique "mechanic" are the awakened abilities. It would be cool to include these in the API along with stats for how they affect each weapon.

LartTyler commented 4 years ago

Safi'jiiva Siege events (and all Iceborne events) will now show up in the events API with v1.17.0. Going to leave this issue open for continued discussion about supporting Safi'jiiva weapons.

DeveloperPaul123 commented 4 years ago

I went ahead and added Rajang to the API